Skip to content

Commit

Permalink
Fix no-new-mixins (emberjs#1099)
Browse files Browse the repository at this point in the history
A new version of the `eslint-plugin-ember` caught a few more cases
in this file. Since it's intentional here, we should just disable
the rule for the whole file.
  • Loading branch information
chancancode authored and nummi committed Apr 5, 2020
1 parent ba22de9 commit 8307f14
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions tests/ember_debug/object-inspector-test.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-new-mixins */
import { find, settled, visit } from '@ember/test-helpers';
import Mixin from '@ember/object/mixin';
import Component from '@ember/component';
Expand Down Expand Up @@ -222,7 +223,6 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Correct mixin order with es6 class', function (assert) {

class MyMixinClass extends Mixin {
toString() {
return 'MyMixin';
Expand Down Expand Up @@ -329,14 +329,11 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Correct mixin properties', function (assert) {

// eslint-disable-next-line ember/no-new-mixins
class MyMixin extends Mixin {
toString() {
return 'MyMixin1';
}
}
// eslint-disable-next-line ember/no-new-mixins
class MyMixin2 extends Mixin {
toString() {
return 'MyMixin2';
Expand Down Expand Up @@ -562,7 +559,6 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Property grouping can be customized using _debugInfo', function(assert) {
// eslint-disable-next-line ember/no-new-mixins
let mixinToSkip = Mixin.create({});

let Inspected = EmberObject.extend(mixinToSkip, {
Expand Down Expand Up @@ -627,7 +623,6 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Property grouping can be customized using _debugInfo when using Proxy', function(assert) {

class MyMixin extends Mixin {
toString() {
return 'MixinToSkip';
Expand Down

0 comments on commit 8307f14

Please sign in to comment.