♻️(contacts) split api test module in actions #573
Merged
+747
−705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
force-pushed
the
qbey/contacts_api_split_tests
branch
from
b56533d
to
ac20eef
Compare
mjeammet
approved these changes
Dec 2, 2024
qbey
force-pushed
the
qbey/contacts_enforce_profile_contact
branch
3 times, most recently
from
9ac2d17
to
c7bbdd6
Compare
Base automatically changed from
qbey/contacts_enforce_profile_contact
to
main
December 3, 2024 15:25
…ore_api_contacts_update.py
…ore_api_contacts_create.py
…ore_api_contacts_retrieve.py
…ore_api_contacts_list.py
…ore_api_contacts_delete.py
…acts/test_core_api_contacts_list.py', 'split/core/tests/test_api_contacts.py-core/tests/contacts/test_core_api_contacts_retrieve.py', 'split/core/tests/test_api_contacts.py-core/tests/contacts/test_core_api_contacts_create.py' and 'split/core/tests/test_api_contacts.py-core/tests/contacts/test_core_api_contacts_update.py' into qbey/contacts_api_split_tests
We need to make several cleanup commits to keep the git history clean.
We need to make several cleanup commits to keep the git history clean.
qbey
force-pushed
the
qbey/contacts_api_split_tests
branch
from
ac20eef
to
514414d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To ease code maintenance and readability, we split the global contact API test module into submodules per action.
This does not impact any feature, the review is just an approval for the PR philosphy.
Proposal