✨(contacts) add notes & force full_name
#565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
force-pushed
the
qbey/contacts_add_fields
branch
2 times, most recently
from
69ac7a3
to
32941fd
Compare
sdemagny
approved these changes
Dec 3, 2024
src/backend/core/factories.py
Outdated
| @@ -115,7 +115,17 @@ class ContactFactory(BaseContactFactory): | |||
| class Meta: | |||
| model = models.Contact | |||
|
|
|||
| base = factory.SubFactory("core.factories.ContactFactory", base=None, owner=None) | |||
| # base = factory.SubFactory("core.factories.ContactFactory", base=None, owner=None) | |||
There was a problem hiding this comment.
tu as oublié de la supprimer ;)
| @@ -20,49 +20,49 @@ def test_models_contacts_str_full_name(): | |||
| def test_models_contacts_base_self(): | |||
| """A contact should not point to itself as a base contact.""" | |||
There was a problem hiding this comment.
Dans ces deux lignes tu ne veux pas renommer le base en override ?
| "{'__all__': ['A contact cannot point to a base contact that itself points to a " | ||
| "base contact.', 'A contact cannot be based on itself.']}" | ||
| "{'__all__': ['A contact cannot point to a base contact that itself overrides " | ||
| "a contact.', 'A contact cannot override itself.']}" | ||
| ) | ||
| assert str(excinfo.value) == error_message | ||
|
|
||
|
|
||
| def test_models_contacts_base_to_base(): | ||
| """A contact should not point to a base contact that is itself derived from a base contact.""" |
| "{'__all__': ['A contact cannot point to a base contact that itself points to a " | ||
| "base contact.']}" | ||
| "{'__all__': ['A contact cannot point to a base contact that itself overrides " | ||
| "a contact.']}" | ||
| ) | ||
| assert str(excinfo.value) == error_message | ||
|
|
||
|
|
||
| def test_models_contacts_owner_base_unique(): | ||
| """There should be only one contact deriving from a given base contact for a given owner.""" |
qbey
force-pushed
the
qbey/contacts_add_fields
branch
from
32941fd
to
17ead08
Compare
We make the full name mandatory and add a field to allow user to store personnal notes on the contact. This also make the "base" contact not mandatory because user may want to create new contacts out of the blue.
To improve code readability, I propose to rename the contact field `override`. This comes along with the fact a contact should not not always override another (it's the case were I only want to create some personal contacts).
qbey
force-pushed
the
qbey/contacts_add_fields
branch
from
17ead08
to
127bd7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We make the full name mandatory and add a field to allow user to store personal notes on the contact.
This also make the "base" contact not mandatory because user may want to create new contacts out of the blue.
Note: this PR also renames the
basefield tooverrideto be more explicit.FIXES #506
Proposal
notesfieldfull_namemandatorybasefield tooverride