🐛(mailboxes) fix logic when attempting to duplicate mailboxes #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic was broken when attempting to duplicate mailboxes, where infos were sent to dimail before checking for uniqueness.
Morendil
reviewed
Nov 19, 2024
| client = APIClient() | ||
| client.force_login(access.user) | ||
| mailbox_values = dict(serializers.MailboxSerializer(existing_mailbox).data) | ||
| # import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Part of me is curious to know the story behind this line (and the one like it below). And part of me is afraid to hear it 😜
There was a problem hiding this comment.
I just wanted to make sure all info were the same but only the local_part field should matter. I'll simplify it right away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Logic was broken when attempting to duplicate mailboxes, where infos were sent to dimail before checking for uniqueness.
Proposal
I'd rather add this logic to a
validatefunction in serializer, but that would require some heavier refacto (addition of domain in serializer or at least in context)