Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed OPF utils PredictionElement #3604

Merged
merged 1 commit into from
May 10, 2017
Merged

Removed OPF utils PredictionElement #3604

merged 1 commit into from
May 10, 2017

Conversation

rhyolight
Copy link
Member

@rhyolight rhyolight commented May 10, 2017 •
edited
Loading

fixes #3603

@rhyolight rhyolight requested a review from scottpurdy May 10, 2017 15:59
scottpurdy
scottpurdy approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@scottpurdy scottpurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue outlining this I thought you mentioned a vague reference to this elsewhere in the code? Do we need to update that too?

@rhyolight
Copy link
Member Author

@scottpurdy The vague reference is here. I did not want to remove the test because I wasn't sure what it was testing. It could just be poorly named.

@rhyolight rhyolight merged commit 3604739 into numenta:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottpurdy scottpurdy scottpurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nupic.framworks.opf.opf_utils.PredictionElement is never used
2 participants
@rhyolight @scottpurdy