Rebuild Capture G1 #474
Merged
Rebuild Capture G1 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Chien <[email protected]>
Signed-off-by: James Chien <[email protected]>
Signed-off-by: James Chien <[email protected]>
Use first() and untilDestroyed() to make sure the subscription terminates after the navigation. Zombie subscription is horrible 🧟 Signed-off-by: James Chien <[email protected]>
Refresh PostCapture whenever navigated to /home and focus on PostCaptureTab. When the PostCaptureTab is initially created, it doesn't need the navigation event (use startwith to force the first emitting), so landing on home page and go to PostCaptureTab can work correctly, as well as when the PostCaptureTab component is destoryed and re-created. Signed-off-by: James Chien <[email protected]>
Use single observable to handle next-page data loading. The first batch of fetching is considered as well, so all relevant race conditions should be fixed now. However, the code is a bit messy. Need refactoring later. Signed-off-by: James Chien <[email protected]>
seanwu1105
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostCatpureTabComponentShareServicesharable_copyurl fails (most likely because of CORS error), catch the error and use download API instead. It's implemented as fallback since the former method does not always fails and is usually faster than the latter method.SendPostCapturePagePostCaptureTabComponentwith messy code. All fetching are handled in a single subscription.