Feature in app puchase #1718
Feature in app puchase #1718
Conversation
| ) {} | ||
|
|
||
| ngOnInit() { | ||
| this.store.refreshNumPointsPricing(); |
There was a problem hiding this comment.
Uncaught exception in test here:
https://github.com/numbersprotocol/capture-lite/runs/6976944629?check_suite_focus=true
It doesn't seem to affect functionality. Maybe just catch this error.
There was a problem hiding this comment.
@shc261392 sure will wrap to try-catch block. By the way, do we need to add BUBBLE_API_URL to the GitHub builds env vars?
| <ion-content *transloco="let t"> | ||
| <ion-list lines="none"> | ||
| <ion-list-header *ngIf="(totalProducts$ | async) === 0"> | ||
| In App Products are not available yet. Try again later |
There was a problem hiding this comment.
Is it ok for this message to be English-only without translation?
src/assets/i18n/zh-tw.json
Outdated
| "pointsAdded": "加了{{points}}分", | ||
| "failedToAddPoints": "加分失敗", | ||
| "thisPackageIncludesXNumPoints": "此套餐包括{{points}}個 NUM 分。", |
There was a problem hiding this comment.
This part is not very intuitive for Chinese speaker users. Maybe consult with Sofia for translations?
src/assets/i18n/zh-tw.json
Outdated
| @@ -348,5 +356,9 @@ | |||
| "pleaseUpdateTheAppForProperFunctioning": "請更新應用程序以使其正常運行", | |||
| "remindMeTomorrow": "明天提醒我", | |||
| "updateNow": "現在更新" | |||
| }, | |||
| "inAppPurchase": { | |||
| "failedToInitInAppStore": "In-App Store 初始化期間發生錯誤。 請檢查您的互聯網連接質量。", | |||
There was a problem hiding this comment.
The wording is in Simplified-Chinese style and may get dislikes for Traditional Chinese users. Might need to consult with Sofia to adjust the translation.
…otocol/capture-lite into feature-in-app-puchase
┆Issue is synchronized with this Asana task by Unito