Add np.asfarray impl

[guilhermeleobas]

As title. I've updated types.float_ to be types.float64 instead of types.float32. On NumPy, at least on my machine, np.float_ is np.float64.

[guilhermeleobas]

Ready for a round of reviews

[stuartarchibald]

Thanks for the patch.

As title. I've updated types.float_ to be types.float64 instead of types.float32. On NumPy, at least on my machine, np.float_ is np.float64.

What does this mean?! I can't see related changes to the fundamental type in the patchset.

[guilhermeleobas]

Thanks for the patch.

As title. I've updated types.float_ to be types.float64 instead of types.float32. On NumPy, at least on my machine, np.float_ is np.float64.

What does this mean?! I can't see related changes to the fundamental type in the patchset.

I've undone those changes because it was breaking some tests.

[guilhermeleobas]

PR is ready for a review

[guilhermeleobas]

Thanks for the review @luk-f-a. I've fixed the code to support complex types.

[luk-f-a]

@guilhermeleobas thanks for the changes, it looks good to me.

[guilhermeleobas]

cc @hameerabbasi

[hameerabbasi]

LGTM. Thanks!

[guilhermeleobas]

Hi, @stuartarchibald

When you have some cycles to spare, can you take a look in this PR?

[stuartarchibald]

Thanks for implementing this, I've given it an initial review, looks good, just one thing to resolve.

[stuartarchibald]

think this ought to be dtype=np.float64?

[stuartarchibald]

and then something check that the thing passed in is actually a dtype or can be accepted and converted to one?

[guilhermeleobas]

Is the check necessary? if dtype is not a subdtype of np.inexact, then, dtype will be assigned to types.float64.

[stuartarchibald]

ok, I think the check can be skipped as the as_dtype will pick up nonsense types.

[stuartarchibald]

Thanks for the fixes, looks good!

[stuartarchibald]

Note: CI fail is #5973

[guilhermeleobas]

Thanks for the review @stuartarchibald