Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export LLVM symbols when linking statically #730

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Don't export LLVM symbols when linking statically #730

merged 5 commits into from
Jun 23, 2021

Conversation

esc
Copy link
Member

@esc esc commented Jun 14, 2021

As title.

@stuartarchibald stuartarchibald changed the title Don't export LLVM symbols when lining statically Don't export LLVM symbols when linking statically Jun 16, 2021
@esc esc force-pushed the llvm/dont_export branch from e1f251d to 9414505 Compare June 16, 2021 18:26
@esc
Copy link
Member Author

esc commented Jun 17, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@esc esc force-pushed the llvm/dont_export branch 3 times, most recently from 9c3f6fd to 5115727 Compare June 17, 2021 15:26
@esc esc mentioned this pull request Jun 17, 2021
Closed
@esc esc force-pushed the llvm/dont_export branch from 5115727 to 534b39a Compare June 17, 2021 15:36
esc added 2 commits June 17, 2021 17:37
@esc
don't ignore LLVMPY symbols
fa90582 
As title
@esc
fix symbol export on OSX
53f868d 
We can not use constructs like `-Wl,-unexported_symbol,_LLVM*` to remove
LLVM symbols, since we also require the LLVMPY symbols to be exported.
So, instead we choose to only export the LLVMPY symbols and ignore
everything else.
stuartarchibald
stuartarchibald approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. This has been checked on OSX via an OOB conversation, the essence of which was running nm on the DSO and looking for symbols with type T. On linux, the changes now match the flags set in ffi/Makefile.linux.

@stuartarchibald stuartarchibald added this to the Version 0.37.0 RC milestone Jun 22, 2021
@esc esc merged commit 132f7f2 into numba:master Jun 23, 2021
@esc
Copy link
Member Author

esc commented Jun 23, 2021

@stuartarchibald thanks for the approval!

@esc esc deleted the llvm/dont_export branch June 30, 2021 14:29
@stuartarchibald stuartarchibald mentioned this pull request Aug 12, 2021
Closed
@stuartarchibald stuartarchibald mentioned this pull request Feb 23, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge
Projects
None yet
Milestone
Version 0.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@esc @stuartarchibald @chrisburr