Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to LLVM 7 #404

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Move to LLVM 7 #404

merged 3 commits into from
Oct 26, 2018

Conversation

stuartarchibald
Copy link
Contributor

As title.

@stuartarchibald stuartarchibald added 3 - Ready for Review Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Oct 18, 2018
@stuartarchibald
Copy link
Contributor Author

stuartarchibald commented Oct 18, 2018

CI will need an llvmdev==7.x build pushing to anaconda.org for it to have a chance of passing.

@anton-malakhov
Copy link
Contributor

anton-malakhov commented Oct 18, 2018

If you want to fork/merge recipe from conda-forge/llvmdev-feedstock, please add that the second part of the merged patch is published as https://reviews.llvm.org/D53035 (the first part is referred in the patch file already)

@stuartarchibald
Copy link
Contributor Author

RE: #404 (comment) thanks, I'll note that in the meta.yaml at the point of patch inclusion.

As title.

* Bumps llvmdev to LLVM 7.

  * Adjusts patches and applies those from @anton-malakhov as per:
    conda-forge/llvmdev-feedstock#47
  * Removes dead patches
  * Removes build forking for PPC64LE

* Updates llvmlite internals and docs reflect the version changes.
As title, responding to feedback.
@stuartarchibald
Copy link
Contributor Author

@anton-malakhov comment added in 0192016

Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good. Thanks for the patch!

@sklam sklam added BuildFarm Passed For PRs that have been through the buildfarm and passed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Oct 26, 2018
@sklam sklam merged commit ebc4c59 into numba:master Oct 26, 2018
@stuartarchibald stuartarchibald mentioned this pull request Oct 30, 2018
stuartarchibald added a commit to stuartarchibald/llvmlite that referenced this pull request Oct 31, 2018
stuartarchibald added a commit to stuartarchibald/llvmlite that referenced this pull request Oct 31, 2018
stuartarchibald added a commit to stuartarchibald/llvmlite that referenced this pull request Oct 31, 2018
stuartarchibald added a commit to stuartarchibald/llvmlite that referenced this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review BuildFarm Passed For PRs that have been through the buildfarm and passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants