Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable numalogic metrics #393

Merged
merged 16 commits into from
Jun 17, 2024
Merged

feat!: enable numalogic metrics #393

merged 16 commits into from
Jun 17, 2024

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Jun 12, 2024

Update metrics for udfs

@s0nicboOm s0nicboOm marked this pull request as ready for review June 12, 2024 19:54
@s0nicboOm s0nicboOm force-pushed the numalogic-metrics branch from 87473cc to 47f0ebd Compare June 12, 2024 20:00
numalogic/transforms/_stateless.py Show resolved Hide resolved
numalogic/udfs/__main__.py Outdated Show resolved Hide resolved
numalogic/udfs/_metrics_utility.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
s0nicboOm added 14 commits June 17, 2024 11:14
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm s0nicboOm force-pushed the numalogic-metrics branch from bb3d09d to beef275 Compare June 17, 2024 18:15
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 77.85235% with 33 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (9d4ea32) to head (0f4457f).

Current head 0f4457f differs from pull request most recent head 54275bd

Please upload reports for the commit 54275bd to get more accurate results.

Files Patch % Lines
numalogic/udfs/_metrics_utility.py 63.51% 21 Missing and 6 partials ⚠️
numalogic/udfs/__main__.py 62.50% 3 Missing ⚠️
numalogic/transforms/_stateless.py 60.00% 1 Missing and 1 partial ⚠️
numalogic/udfs/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   92.62%   92.30%   -0.33%     
==========================================
  Files          99       97       -2     
  Lines        4760     4782      +22     
  Branches      419      430      +11     
==========================================
+ Hits         4409     4414       +5     
- Misses        256      270      +14     
- Partials       95       98       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
Signed-off-by: Kushal Batra <[email protected]>
@s0nicboOm s0nicboOm merged commit 7fa698c into main Jun 17, 2024
11 checks passed
@s0nicboOm s0nicboOm deleted the numalogic-metrics branch June 17, 2024 20:20
@ab93 ab93 changed the title Numalogic metrics feat!: enable numalogic metrics Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants