Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing logger level setting #205

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented Jun 5, 2023

Fix: Logging and docstring

@s0nicboOm s0nicboOm marked this pull request as ready for review June 5, 2023 22:42
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #205 (853d953) into main (521f0b9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   96.55%   96.55%   -0.01%     
==========================================
  Files          40       40              
  Lines        1597     1596       -1     
  Branches      125      125              
==========================================
- Hits         1542     1541       -1     
  Misses         42       42              
  Partials       13       13              
Impacted Files Coverage Δ
numalogic/__init__.py 100.00% <ø> (ø)
numalogic/registry/redis_registry.py 97.63% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pyproject.toml Outdated Show resolved Hide resolved
@s0nicboOm s0nicboOm merged commit b93bce5 into numaproj:main Jun 5, 2023
@s0nicboOm s0nicboOm deleted the log_fix branch June 5, 2023 22:54
ab93 pushed a commit that referenced this pull request Jun 6, 2023
Fix: Logging and docstring

---------

Signed-off-by: s0nicboOm <[email protected]>
ab93 pushed a commit that referenced this pull request Jun 6, 2023
Fix: Logging and docstring

---------

Signed-off-by: s0nicboOm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants