Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.11 #68

Closed
ab93 opened this issue Oct 30, 2022 · 7 comments
Closed

Support Python 3.11 #68

ab93 opened this issue Oct 30, 2022 · 7 comments
Assignees
@tcchawla
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@ab93
Copy link
Member

ab93 commented Oct 30, 2022 •
edited
Loading

  • Add workflow to make sure 3.11 build succeeds
  • Update pyproject.toml file to support python 3.11.x versions

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
@ab93 ab93 added the enhancement New feature or request label Oct 30, 2022
@tcchawla
Copy link
Contributor

Can I work on this issue?

@ab93 ab93 added the good first issue Good for newcomers label Oct 31, 2022
@ab93
Copy link
Member Author

ab93 commented Oct 31, 2022

Of course @tcchawla . Let me know if you need any help or info on this. :)

@tcchawla tcchawla mentioned this issue Nov 1, 2022
Closed
@tcchawla
Copy link
Contributor

tcchawla commented Nov 1, 2022

Hello @ab93, I have created a PR solving this issue #72.

@ab93
Copy link
Member Author

ab93 commented Nov 1, 2022

hi @tcchawla thank you so much for the PR. Unfortunately, torch does not support 3.11 yet. Can you pick another issue for the time being. Would love some help on some of the other issues. :)

@tcchawla
Copy link
Contributor

tcchawla commented Nov 2, 2022

Sure @ab93, I will take other issues.

@tcchawla
Copy link
Contributor

tcchawla commented Nov 2, 2022

Hey @ab93, PyTorch has rolled out beta for Python 3.11 - here https://pytorch.org/blog/PyTorch-1.13-release/
Also, in their nightly builds they have built support for 3.11 version - pytorch/pytorch#86566 (comment)

@ab93
Copy link
Member Author

ab93 commented Nov 3, 2022

Correct. :) Good find. We avoid nightly versions to keep the library stable. Let's keep an eye out, and merge this when they push out a stable version.

@tcchawla tcchawla mentioned this issue Jun 8, 2023
Merged
ab93 pushed a commit that referenced this issue Jun 8, 2023
@tcchawla
Upgraded python support for 3.11 (#211)
203c100 
Solves issue: #68 

This PR adds support for latest python 3.11 version
Changed workflow to support the latest version
Changed project dependency to support 3.11.x versions

Signed-off-by: Tarun Chawla <[email protected]>
ab93 pushed a commit that referenced this issue Jun 20, 2023
@tcchawla @ab93
Upgraded python support for 3.11 (#211)
c41d0d6 
Solves issue: #68 

This PR adds support for latest python 3.11 version
Changed workflow to support the latest version
Changed project dependency to support 3.11.x versions

Signed-off-by: Tarun Chawla <[email protected]>
@ab93 ab93 closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcchawla tcchawla

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ab93 @tcchawla