Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always publish watermark to sink OT #2288

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Dec 15, 2024

Explain what this PR does.

.
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (a32ebbc) to head (8dd384d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
- Coverage   65.58%   65.53%   -0.06%     
==========================================
  Files         346      346              
  Lines       42397    42396       -1     
==========================================
- Hits        27806    27784      -22     
- Misses      13511    13540      +29     
+ Partials     1080     1072       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure why we weren't sending it earlier.

@whynowy whynowy merged commit 883650c into numaproj:main Dec 15, 2024
25 checks passed
@whynowy whynowy deleted the sss branch December 15, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants