Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Add the required changes for F-Droid #153

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Kusoneko
Copy link

@Kusoneko Kusoneko commented Apr 19, 2024

[X]dbaf771 : Changes the versioning code scheme from the default abi * 1000 + vercode to vercode * 10 + abi, as requested by the F-Droid dev linsui at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13506#note_1608664649 This is a breaking change, as updating from the previous version to this one will likely cause issues as the version code here will be smaller than the one of the previous version, will require people to uninstall fully and reinstall. (If there's an backup/restore feature built in the app, this should be fine, if there isn't, this may cause issues)
[X]1fc0425 : Add distributionSha256Sum field to gradle wrapper properties to ensure the integrity of the downloaded gradle package, prevents attacks where a malicious or corrupt version would be offered for download on the gradle distribution website. This would fix one of the many annoying warnings about this being missing, presumably all the others are located in dependencies, and while it would be preferable to have them do it as well, I'm not likely to go through all of them one by one to ask them to do the same.
[ ] Reproducible build support : As asked by Izzy at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13506#note_1501746673 and recommended by F-Droid in general. I am not sure how to fix the specific issue he mentioned but I'm putting it up here so we can figure it out. Will be linking this in the F-Droid Merge Request so they can come help too if possible, as I'm neither an Android or Flutter dev, so this is all a bit beyond me at the moment.

Finally, this PR should close #152 (can't figure out how to make it close it if merged from here atm though)

@Kusoneko Kusoneko marked this pull request as ready for review April 19, 2024 03:25
@Kusoneko Kusoneko marked this pull request as draft April 19, 2024 03:27
@Kusoneko
Copy link
Author

@nullxception @IzzySoft tagging concerned individuals for now. idk if the f-droid linsui is also the github one so I'm not tagging them rn.

@IzzySoft
Copy link

I'm currently not active at F-Droid, sorry. linsui and/or licaon-kter (add the @ before their names if you need to tag them) would most likely be working on this.

@Kusoneko
Copy link
Author

@IzzySoft their usernames are the same here as on gitlab? Also, unfortunate news that you're inactive at F-Droid. Still, considering the VerCode change if null merges this you might still need to be included as iirc you still have this app in your IzzyOnDroid repo, and that just smells like it's going to end up being a breaking change (I don't think android will like an "upgrade" from 1k, 2k or 4k to 411, 412 or 414) if it gets in considering the need for that change.

@IzzySoft
Copy link

their usernames are the same here as on gitlab?

Yupp. Tested with the @, looks right.

unfortunate news

Since 11/2023, yeah. But you see the reasoning I hope. I was waiting for the situation to be dealt with so I might return, but it doesn't look like it will ever be addressed. I'm still supporting "my" fdroiddata team here and there, mostly "from behind the scenes".

considering the VerCode change

Yupp, the IzzyOnDroid repo would be affected then (auto-updates would stop and I'd have to take manual action; also those having installed the app from here would need to uninstall and reinstall, as Android doesn't permit "downgrades") – so there should be a proper hint in the corresponding per-release changelogs (or maybe even in the app description) to point that out. And I'd need a "ping" when the first such release was made, to take the required actions on my end.

that just smells like it's going to end up being a breaking change

It is. And I don't know why Flutter defaults to such a crazy scheme (ABI * 1000 + vercode) instead to the more sane vercode * 10 + ABI. The latter even allows switching between armeabi and arm64 in both directions when an update comes, theirs does not 🤷‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants