This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X]dbaf771 : Changes the versioning code scheme from the default
abi * 1000 + vercode
tovercode * 10 + abi
, as requested by the F-Droid dev linsui at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13506#note_1608664649 This is a breaking change, as updating from the previous version to this one will likely cause issues as the version code here will be smaller than the one of the previous version, will require people to uninstall fully and reinstall. (If there's an backup/restore feature built in the app, this should be fine, if there isn't, this may cause issues)[X]1fc0425 : Add distributionSha256Sum field to gradle wrapper properties to ensure the integrity of the downloaded gradle package, prevents attacks where a malicious or corrupt version would be offered for download on the gradle distribution website. This would fix one of the many annoying warnings about this being missing, presumably all the others are located in dependencies, and while it would be preferable to have them do it as well, I'm not likely to go through all of them one by one to ask them to do the same.
[ ] Reproducible build support : As asked by Izzy at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13506#note_1501746673 and recommended by F-Droid in general. I am not sure how to fix the specific issue he mentioned but I'm putting it up here so we can figure it out. Will be linking this in the F-Droid Merge Request so they can come help too if possible, as I'm neither an Android or Flutter dev, so this is all a bit beyond me at the moment.
Finally, this PR should close #152 (can't figure out how to make it close it if merged from here atm though)