Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move try...catch inside anonymous function where it should be #65

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Move try...catch inside anonymous function where it should be #65

merged 1 commit into from
Jan 13, 2023

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Jan 12, 2023

The try...catch was only protecting the return of the anonymous function, which was useless. It should be part of the returned function to catch actual processing errors.

@mbklein mbklein requested a review from bmquinn January 12, 2023 18:42
@mbklein mbklein merged commit 4a1494b into deploy/staging Jan 13, 2023
@bmquinn bmquinn deleted the fix-middleware-wrap branch January 19, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmquinn bmquinn bmquinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbklein @bmquinn