Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer the search context's size over the default #50

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Nov 28, 2022

To test:

First, your dev index must have at least 2 pages of works in it for whatever page size you choose to test with.

POST a query that includes a size attribute in the JSON, e.g.:

curl --data '{"size":50, "query":{"bool":{"must":[{"match":{"api_model":"Work"}}, {"query_string":{"query":"collection.id:18ec4c6b-192a-4ab8-9903-ea0f393c35f7"}}]}}}' http://localhost:3000/search

Watch the pagination blocks as you page through results.

@mbklein mbklein requested a review from kdid November 28, 2022 19:51
@bmquinn bmquinn merged commit 148cc3a into deploy/staging Nov 28, 2022
@bmquinn bmquinn deleted the 3374-pagination-bug branch November 28, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants