Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds /auth/logout handler #40

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Adds /auth/logout handler #40

merged 1 commit into from
Oct 28, 2022

Conversation

bmquinn
Copy link
Contributor

@bmquinn bmquinn commented Oct 28, 2022

Description

  • Adds /auth/logout handler with tests
    • makes a get request to the NUSSO logout endpoint
    • expires the dcApiV2Token so that later to requests to whoami endpoint error out as expected

Steps to test

  • log in using /auth/login (I use ?goto=[dev env url]/auth/whoami)
  • log out using /auth/logout and make sure you land on the NU logout page
  • double check the auth/whoami route to make sure the dcApiV2Token no longer returns your user data

@bmquinn bmquinn requested a review from kdid October 28, 2022 19:15
@bmquinn bmquinn temporarily deployed to test October 28, 2022 20:50 Inactive
@bmquinn bmquinn merged commit 65526b8 into deploy/staging Oct 28, 2022
@bmquinn bmquinn deleted the 3227-auth-logout branch October 28, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdid kdid kdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmquinn @kdid