Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shared link expiration to work response #144

Merged
merged 1 commit into from
May 23, 2023
Merged

Add shared link expiration to work response #144

merged 1 commit into from
May 23, 2023

Conversation

kdid
Copy link
Contributor

@kdid kdid commented May 23, 2023

  • Addslink_expiration to API response in the info section.
  • If it is a shared-links/id request, populate link_expiration with the shared link expiration, otherwise it's null

@kdid kdid force-pushed the 3334-shared-link-expiration branch from 6ed6d57 to 36bba39 Compare May 23, 2023 18:34
@kdid kdid temporarily deployed to test May 23, 2023 18:34 — with GitHub Actions Inactive
bmquinn
bmquinn approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@bmquinn bmquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kdid kdid merged commit 7244612 into deploy/staging May 23, 2023
@kdid kdid deleted the 3334-shared-link-expiration branch May 23, 2023 19:14
@kdid kdid temporarily deployed to staging May 23, 2023 19:14 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmquinn bmquinn bmquinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdid @bmquinn