Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some naming confusion here because (from previous commits)
test-helpers.js
injects ahelpers
object into the global context. But I've also just addedsrc/helpers.js
. Since the globalhelpers
object doesn't exist at runtime, there's no concern about requiring it in any code undersrc
, and so far I'm just usingconst { baseUrl } = require("path/to/helpers")
inhelpers.test.js
to avoid a collision. But if the presence of both is awkward, I'm open to suggestions, e.g.,helpers
object totestHelpers
or_helpers
or something elsehelpers.js
file to something else (though we're already trying to avoidutils
, but then again, ishelpers
any better?)