Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to search #11

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add pagination to search #11

merged 1 commit into from
Aug 15, 2022

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Aug 15, 2022

There's some naming confusion here because (from previous commits) test-helpers.js injects a helpers object into the global context. But I've also just added src/helpers.js. Since the global helpers object doesn't exist at runtime, there's no concern about requiring it in any code under src, and so far I'm just using const { baseUrl } = require("path/to/helpers") in helpers.test.js to avoid a collision. But if the presence of both is awkward, I'm open to suggestions, e.g.,

  • rename the global test-mode-only helpers object to testHelpers or _helpers or something else
  • rename the new helpers.js file to something else (though we're already trying to avoid utils, but then again, is helpers any better?)

@mbklein mbklein requested a review from kdid August 15, 2022 17:38
@mbklein mbklein marked this pull request as draft August 15, 2022 17:45
@mbklein mbklein force-pushed the 3083-paginate-search branch 2 times, most recently from b2cbfd9 to 1c86895 Compare August 15, 2022 18:35
@mbklein mbklein marked this pull request as ready for review August 15, 2022 18:42
@mbklein mbklein force-pushed the 3083-paginate-search branch from 1c86895 to 18ef486 Compare August 15, 2022 18:46
@mbklein mbklein force-pushed the 3083-paginate-search branch from 18ef486 to 7b1e480 Compare August 15, 2022 18:47
@kdid kdid merged commit be52fed into deploy/staging Aug 15, 2022
@kdid kdid deleted the 3083-paginate-search branch August 15, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants