Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing endpoints #25

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Add missing endpoints #25

merged 4 commits into from
Jan 8, 2021

Conversation

mmktomato
Copy link
Member

@mmktomato mmktomato commented Dec 31, 2020 •
edited
Loading

Resolves #23

  • Add missing endpoints.
  • Put warning messages when using deprecated endpoints.
  • Re-format comments.
    • Omit numbers.
    • English urls.
    • nulab-inc.com to nulab.com.

TODOs

  • Manual test for added endpoints.
  • Manual test for deprecation messages.

@mmktomato mmktomato changed the title Missing endpoints Add missing endpoints Dec 31, 2020
@mmktomato mmktomato marked this pull request as ready for review January 7, 2021 09:11
@mmktomato mmktomato requested a review from vvatanabe January 7, 2021 09:11
@mmktomato
Copy link
Member Author

@vvatanabe
Could you please review this?

@vvatanabe
Copy link
Member

@mmktomato OK! I will chk it ASAP :D

@vvatanabe
Copy link
Member

@mmktomato I checked new api's below. Super Thanks! LGTM!

  • getProjectStatuses
  • postProjectStatus
  • patchProjectStatus
  • deleteProjectStatus
  • patchProjectStatusOrder
  • deleteIssueComment
  • getIssueParticipants
  • getTeams
  • postTeam
  • getTeam
  • patchTeam
  • deleteTeam
  • getTeamIcon
  • getProjectTeams
  • postProjectTeam
  • deleteProjectTeam

@mmktomato mmktomato merged commit df80272 into master Jan 8, 2021
@mmktomato mmktomato deleted the missing-endpoints branch January 8, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvatanabe vvatanabe Awaiting requested review from vvatanabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing endpoints
2 participants
@mmktomato @vvatanabe