Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type declaration of Entity.Issue.Issue has issues #79

Closed
tockri opened this issue Jul 21, 2023 · 1 comment · Fixed by #80
Closed

type declaration of Entity.Issue.Issue has issues #79

tockri opened this issue Jul 21, 2023 · 1 comment · Fixed by #80

Comments

@tockri
Copy link

tockri commented Jul 21, 2023

Hi, thank you for great library!
I found subtle issues on Issue declaration.
https://github.com/nulab/backlog-js/blob/master/src/entity.ts#L233

  export interface Issue {
    id: number;
     :
    keyId: 1;    // <---- should be number
     :
    resolution: Resolution; // <----- should be Resolution | undefined
     :
    assignee: User.User; // <------ should be User.User | undefined
     :
  }

Please consider fixing 🙏

mmktomato added a commit that referenced this issue Jul 21, 2023
mmktomato added a commit that referenced this issue Jul 21, 2023
@mmktomato
Copy link
Member

@tockri Thank you for the report! I fixed it and released 0.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants