Loader migrated to TS #1002 #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
haidang666
reviewed
Sep 27, 2021
| Loader.propTypes = { | ||
| type: PropTypes.string | ||
| }; | ||
|
|
||
| Loader.defaultProps = { |
There was a problem hiding this comment.
I think it's better to put default prop like this
const Loader: React.FC<LoaderProps> = ({
type='default'
}) => {There was a problem hiding this comment.
yeah, I was initially going to go with this. Will change.
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
- Coverage 61.43% 61.42% -0.02%
==========================================
Files 280 280
Lines 5002 5000 -2
Branches 318 318
==========================================
- Hits 3073 3071 -2
Misses 1662 1662
Partials 267 267
Continue to review full report at Codecov.
|
|
Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/ui/lib/components/Loadermigrated to Typescript.