Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save track id from stream provider #1048

Merged
merged 7 commits into from
Oct 5, 2021

Conversation

haidang666
Copy link
Collaborator

close #673

@codecov
Copy link

codecov bot commented Sep 5, 2021

Codecov Report

Merging #1048 (8d53cb8) into master (c4ef0f1) will decrease coverage by 0.09%.
The diff coverage is 31.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   61.43%   61.34%   -0.10%     
==========================================
  Files         280      280              
  Lines        5002     5073      +71     
  Branches      318      326       +8     
==========================================
+ Hits         3073     3112      +39     
- Misses       1662     1688      +26     
- Partials      267      273       +6     
Impacted Files Coverage Δ
...ges/app/app/components/FavoriteTracksView/index.js 75.75% <ø> (+27.27%) ⬆️
...ponents/PlayQueue/QueueMenu/QueueMenuMore/index.js 64.51% <ø> (+9.67%) ⬆️
...ages/app/app/containers/QueuePopupButtons/index.js 67.50% <ø> (+10.00%) ⬆️
packages/core/src/plugins/stream/AudiusPlugin.ts 15.15% <0.00%> (-2.71%) ⬇️
packages/core/src/plugins/stream/BandcampPlugin.ts 12.50% <0.00%> (-2.89%) ⬇️
...ackages/core/src/plugins/stream/InvidiousPlugin.ts 15.15% <0.00%> (-3.37%) ⬇️
packages/core/src/plugins/stream/JamendoPlugin.ts 16.66% <0.00%> (-7.15%) ⬇️
...ckages/core/src/plugins/stream/SoundcloudPlugin.ts 16.66% <0.00%> (-3.34%) ⬇️
packages/core/src/plugins/stream/YoutubePlugin.ts 16.66% <0.00%> (-2.39%) ⬇️
...ges/core/src/plugins/stream/iTunesPodcastPlugin.ts 13.15% <0.00%> (-0.74%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ef0f1...8d53cb8. Read the comment docs.

@haidang666 haidang666 marked this pull request as ready for review September 6, 2021 15:11
@haidang666 haidang666 added the under review This pull request is being reviewed by maintainers. label Sep 7, 2021
@nukeop nukeop added needs changes The author needs to make changes to this pull request. and removed under review This pull request is being reviewed by maintainers. labels Sep 20, 2021
@nukeop nukeop merged commit 00c7260 into nukeop:master Oct 5, 2021
@haidang666 haidang666 deleted the remember-track-id branch October 12, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changes The author needs to make changes to this pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember source when a track is added to favourites
2 participants