Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskbar Icon not rendering correctly/completely #1044

Closed
LaSanya2001 opened this issue Aug 30, 2021 · 9 comments
Closed

Taskbar Icon not rendering correctly/completely #1044

LaSanya2001 opened this issue Aug 30, 2021 · 9 comments
Labels
bug This issue identifies a bug in Nuclear. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. help needed - Windows We're stuck and we need someone with access to Windows to help debug this

Comments

@LaSanya2001
Copy link

Platform: Windows 10 Ver. 2004 Build 19041.1165

Nuclear version: 0.6.16

Description of the issue: The Logo/Icon of Nuclear is not rendering properly in the taskbar, as only the top most slither of it is rendered, and the rest is blankspace. I've stumbled upon this Issue in previous versions and it doesn't depend on wether I've downloaded Nuclear through winget or directly from the [site/github.]

A link to a screenshot
(https://i.imgur.com/ts9iMu2.png)

@LaSanya2001 LaSanya2001 added the bug This issue identifies a bug in Nuclear. label Aug 30, 2021
@nukeop nukeop added the help needed - Windows We're stuck and we need someone with access to Windows to help debug this label Aug 30, 2021
@nukeop
Copy link
Owner

nukeop commented Aug 30, 2021

Thanks for reporting, we'll need someone with access to Windows to debug this.

@nukeop nukeop added the good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. label Aug 30, 2021
@PriyanshX1902
Copy link

@nukeop can I take up this issue?

@nukeop
Copy link
Owner

nukeop commented Sep 8, 2021

Sure, if you can test this on Windows it would be great.

@PriyanshX1902
Copy link

image
It renders fine in the taskbar when I run the application on my Windows 10.

@nukeop
Copy link
Owner

nukeop commented Sep 8, 2021

Ok, somebody who can reproduce this will need to take a look then.

@LaSanya2001
Copy link
Author

If this helps any in relation to rendering, my gpu is a Zotac Geforce 970 and I have an I7-4770K. I presume it is not a problem directly related to Electron, since Discord displays fine, but I am a very novice coder if anything, so take that with a big grain of salt.

@Venryx
Copy link
Contributor

Venryx commented Sep 8, 2021

I get the same issue as the OP on Windows:

I'm using an old version though (0.6.6), so it's possible it was fixed since then?

Anyway, I'm too lazy to debug it right now, but responding here for reference.

@anan93636369
Copy link

I got the same issue as the OP on windowsimageI'm using the 0.6.16 version with windows 21H1 19043.1237

1lluzi0nzz pushed a commit to MSU-CS4360-Nuclear/nuclear that referenced this issue Sep 21, 2021
nukeop pushed a commit that referenced this issue Sep 30, 2021
Co-authored-by: Jacob Netwal <[email protected]>
Co-authored-by: jreiser1 <[email protected]>
Co-authored-by: Hardik <[email protected]>
Co-authored-by: Felix <[email protected]>
Co-authored-by: Jacob Reiser <[email protected]>
@nukeop
Copy link
Owner

nukeop commented Sep 30, 2021

Fixed by #1057, thank you @1lluzi0nzz et al

@nukeop nukeop closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a bug in Nuclear. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. help needed - Windows We're stuck and we need someone with access to Windows to help debug this
Projects
None yet
Development

No branches or pull requests

5 participants