Python bindings as a feature of the main crate #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
===========================================
- Coverage 81.15% 68.44% -12.72%
===========================================
Files 15 16 +1
Lines 1125 1334 +209
===========================================
Hits 913 913
- Misses 212 421 +209
Continue to review full report at Codecov.
|
fjarri
force-pushed
the
bindings-as-features
branch
4 times, most recently
from
6e43341 to
3334e96
Compare
No need to specify the target explicitly, and for some reason it breaks the CI (by triggering cross-compilation machinery in pyo3).
fjarri
changed the title
fjarri
force-pushed
the
bindings-as-features
branch
from
3334e96 to
d599a47
Compare
fjarri
added
API
fjarri
force-pushed
the
bindings-as-features
branch
from
d599a47 to
0194b47
Compare
fjarri
changed the title
fjarri
force-pushed
the
bindings-as-features
branch
from
0194b47 to
f6287e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bindings in https://github.com/nucypher/nucypher-core need access to some Umbral objects, we need to expose the Rust side of the bindings in Umbral. Otherwise objects coming from two different binary-backed libraries would be incompatible.
This PR moves the Python bindings to a feature-gated submodule of the main library. Other possible way is to have a separate
umbral-pre-pythoncrate with the bindings, and import that. Would that be better?