Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization methods for Eth contracts #115

Merged
merged 7 commits into from
Jan 17, 2023

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Jan 17, 2023

  • Added Signature::to_be_bytes(), Capsule::to_bytes_simple(), and CapsuleFrag::to_bytes_simple() to use in Ethereum contracts.

Also:

  • Added the missing VerifiedCapsuleFrag::unverify() method in WASM bindings.
  • Added the missing Signature::to_der_bytes() and from_der_bytes() that were missing in the Rust library but present in the bindings.

@codecov-commenter
Copy link

Codecov Report

Merging #115 (4292071) into master (1b24c75) will decrease coverage by 1.65%.
The diff coverage is 23.25%.

❗ Current head 4292071 differs from pull request most recent head 9569a34. Consider uploading reports for the commit 9569a34 to get more accurate results

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   47.39%   45.75%   -1.65%     
==========================================
  Files          17       17              
  Lines        1019     1049      +30     
==========================================
- Hits          483      480       -3     
- Misses        536      569      +33     
Impacted Files Coverage Δ
umbral-pre/src/bindings_python.rs 0.00% <0.00%> (ø)
umbral-pre/src/bindings_wasm.rs 0.00% <0.00%> (ø)
umbral-pre/src/capsule_frag.rs 65.38% <0.00%> (-14.31%) ⬇️
umbral-pre/src/keys.rs 65.38% <66.66%> (-1.29%) ⬇️
umbral-pre/src/capsule.rs 87.80% <100.00%> (-0.44%) ⬇️
umbral-pre/src/pre.rs 85.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fjarri fjarri merged commit be5fd92 into nucypher:master Jan 17, 2023
@fjarri fjarri deleted the contract-serialization branch January 17, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants