Return rephrased query in results #2870
Merged
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2870 +/- ##
==========================================
- Coverage 86.90% 86.84% -0.06%
==========================================
Files 382 382
Lines 24184 24192 +8
==========================================
- Hits 21016 21010 -6
- Misses 3168 3182 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jotare
approved these changes
Feb 12, 2025
| @@ -120,6 +120,7 @@ async def _index_node_retrieval( | |||
| results, | |||
| kbid=kbid, | |||
| query=pb_query.body, | |||
| rephrased_query=await query_parser.fetcher.get_rephrased_query(), | |||
There was a problem hiding this comment.
The fetcher inside the QueryParser class was more a middle step while moving thing to query_parser module, I don't love exposing it here.
There was a problem hiding this comment.
I can proxy the get_rephrased_query function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.