Update tools and use make to run them

nucleos · Dec 6, 2021 · e604abb · e604abb
1 parent 1248b55
commit e604abb
Show file tree

Hide file tree

Showing 8 changed files with 710 additions and 669 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -31,9 +31,6 @@ jobs:
           extensions: "mbstring, json"
           php-version: ${{ matrix.php-version }}
 
-      - name: "Validate composer.json and composer.lock"
-        run: composer validate --strict
-
       - name: "Cache dependencies installed with composer"
         uses: actions/[email protected]
         with:
@@ -45,8 +42,8 @@ jobs:
       - name: "Install locked dependencies with composer"
         run: composer install --no-interaction --no-progress --no-suggest
 
-      - name: "Run localheinz/composer-normalize"
-        run: composer normalize --dry-run
+      - name: "Run composer lint"
+        run: make lint-composer
 
       - name: "Create cache directory for friendsofphp/php-cs-fixer"
         run: mkdir -p .build/php-cs-fixer
@@ -60,7 +57,9 @@ jobs:
             php${{ matrix.php-version }}-php-cs-fixer-
 
       - name: "Run friendsofphp/php-cs-fixer"
-        run: composer cs-diff
+        env:
+            PHP_CS_FIXER_IGNORE_ENV: 1
+        run: make cs
 
   static-code-analysis:
     name: "Static Code Analysis"
@@ -95,13 +94,13 @@ jobs:
         run: composer install --no-interaction --no-progress --no-suggest
 
       - name: "Run phpstan/phpstan"
-        run: composer phpstan
+        run: make phpstan
 
       - name: "Run psalm"
-        run: vendor/bin/psalm --config=psalm.xml --diff --shepherd --show-info=false --stats --threads=4
+        run: make psalm
 
       - name: "Run phpmd"
-        run: composer phpmd
+        run: make phpmd
 
   tests:
     name: "Test (PHP ${{ matrix.php-version }}, symfony ${{ matrix.symfony }}, ${{ matrix.dependencies }})"
@@ -119,8 +118,8 @@ jobs:
           - highest
 
         symfony:
-          - 4.4
-          - 5.1
+          - 5.4
+          - 6.0
 
     steps:
       - name: "Checkout"
@@ -134,7 +133,8 @@ jobs:
           php-version: ${{ matrix.php-version }}
 
       - name: 'Install Symfony Flex'
-        run: composer global require --prefer-dist --no-progress --no-suggest --ansi symfony/flex
+        run: |
+          composer global require --prefer-dist --no-progress --no-suggest --ansi symfony/flex
 
       - name: "Cache dependencies installed with composer"
         uses: actions/[email protected]
@@ -156,7 +156,7 @@ jobs:
         run: composer update --no-interaction --no-progress --no-suggest
 
       - name: "Run tests with phpunit/phpunit"
-        run: composer test
+        run: make test
 
   code-coverage:
     name: "Code Coverage"
@@ -191,7 +191,7 @@ jobs:
         run: composer install --no-interaction --no-progress --no-suggest
 
       - name: "Collect code coverage with pcov and phpunit/phpunit"
-        run: composer coverage
+        run: make coverage
 
       - name: "Send code coverage report to Codecov.io"
         env:
@@ -206,7 +206,7 @@ jobs:
     strategy:
       matrix:
         php-version:
-          - 8.1
+          - 8.0
 
     steps:
       - name: "Checkout"
@@ -216,7 +216,7 @@ jobs:
         uses: shivammathur/[email protected]
         with:
           coverage: pcov
-          extensions: "mbstring"
+          extensions: "mbstring, json"
           php-version: ${{ matrix.php-version }}
 
       - name: "Cache dependencies installed with composer"
@@ -230,8 +230,5 @@ jobs:
       - name: "Install locked dependencies with composer"
         run: composer install --no-interaction --no-progress --no-suggest
 
-      - name: "Download infection"
-        run: wget -O infection https://github.com/infection/infection/releases/download/0.19.0/infection.phar && chmod +x infection
-
       - name: "Run mutation tests with pcov and infection/infection"
-        run: ./infection
+        run: make infection
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,5 @@
 .php-cs-fixer.cache
+.php-cs-fixer.php
 .phpunit.result.cache
 coverage
 composer.lock
@@ -7,3 +8,4 @@ phpunit.xml
 /vendor/
 !/vendor-bin/tools/composer.lock
 /vendor-bin/tools/vendor/
+/vendor-bin/tools/bin/
diff --git a/.php-cs-fixer.php → .php-cs-fixer.dist.php b/.php-cs-fixer.php → .php-cs-fixer.dist.php
@@ -35,7 +35,10 @@
         ],
         'php_unit_internal_class' => false,
         'php_unit_test_class_requires_covers' => false,
-        'no_superfluous_phpdoc_tags' => true,
+        'no_superfluous_phpdoc_tags' => [
+            'allow_mixed' => true,
+            'remove_inheritdoc' => true,
+        ],
         'static_lambda' => true,
         'global_namespace_import' => [
            'import_classes' => true,

diff --git a/Makefile b/Makefile
@@ -0,0 +1,64 @@
+.PHONY: default
+default: lint
+
+.PHONY: fix
+fix: cs-fix lint-fix
+
+.PHONY: lint
+lint: lint-composer
+
+.PHONY: lint-composer
+lint-composer:
+	composer validate --strict
+	composer normalize --dry-run
+
+.PHONY: test
+test: vendor-bin/tools/vendor
+	vendor/bin/phpunit --colors=always
+
+.PHONY: infection
+infection: vendor/bin/infection
+	vendor/bin/infection --threads=4
+
+.PHONY: coverage
+coverage: vendor-bin/tools/vendor
+	vendor/bin/phpunit --colors=always --coverage-clover=build/logs/clover.xml
+
+.PHONY: cs
+cs: vendor-bin/tools/vendor
+	vendor/bin/php-cs-fixer fix  --verbose --diff --dry-run
+
+.PHONY: cs-fix
+cs-fix: vendor-bin/tools/vendor
+	vendor/bin/php-cs-fixer fix --verbose
+
+.PHONY: psalm
+psalm: vendor-bin/tools/vendor
+	vendor/bin/psalm --config=psalm.xml --diff --shepherd --show-info=false --stats --threads=4
+
+.PHONY: phpstan
+phpstan: vendor-bin/tools/vendor
+	vendor/bin/phpstan analyse
+
+.PHONY: phpmd
+phpmd: vendor-bin/tools/vendor
+	vendor/bin/phpmd src,tests ansi phpmd.xml
+
+.PHONY: lint-fix
+lint-fix:
+	find ./src \\( -name '*.xml' -or -name '*.xml.dist' -or -name '*.xlf' \\) -type f -exec xmllint --encode UTF-8 --output '{}' --format '{}' \\;
+	find ./src \\( -name '*.yml' -or -name '*.yaml' \\) -not -path '*/vendor/*' | xargs yaml-lint
+
+.PHONY: check-dependencies
+check-dependencies: vendor-bin/tools/vendor
+	vendor/bin/composer-require-checker check --config-file composer-require.json composer.json
+
+#
+# Installation tasks
+#
+
+vendor-bin/tools/vendor:
+	composer --working-dir=vendor-bin/tools install
+
+vendor/bin/infection: vendor-bin/tools/vendor
+	wget -O vendor/bin/infection https://github.com/infection/infection/releases/latest/download/infection.phar && chmod +x vendor/bin/infection
diff --git a/composer.json b/composer.json
@@ -1,7 +1,8 @@
 {
     "name": "nucleos/menu-bundle",
-    "type": "symfony-bundle",
     "description": "This bundle provides services for defining static menus for symfony applications.",
+    "license": "MIT",
+    "type": "symfony-bundle",
     "keywords": [
         "symfony",
         "sonata",
@@ -11,14 +12,31 @@
         "knpmenu",
         "generator"
     ],
-    "homepage": "https://nucleos.rocks",
-    "license": "MIT",
     "authors": [
         {
             "name": "Christian Gripp",
             "email": "[email protected]"
         }
     ],
+    "homepage": "https://nucleos.rocks",
+    "funding": [
+        {
+            "type": "github",
+            "url": "https://github.com/sponsors/core23"
+        },
+        {
+            "type": "opencollective",
+            "url": "https://opencollective.com/core23"
+        },
+        {
+            "type": "ko-fi",
+            "url": "https://ko-fi.com/core23"
+        },
+        {
+            "type": "other",
+            "url": "https://donate.core23.de"
+        }
+    ],
     "require": {
         "php": "^8.0",
         "knplabs/knp-menu": "^2.1 || ^3.1",
@@ -37,9 +55,6 @@
         "symfony/browser-kit": "^4.4 || ^5.0",
         "symfony/translation": "^4.2 || ^5.0"
     },
-    "config": {
-        "sort-packages": true
-    },
     "autoload": {
         "psr-4": {
             "Nucleos\\MenuBundle\\": "src/"
@@ -50,42 +65,15 @@
             "Nucleos\\MenuBundle\\Tests\\": "tests/"
         }
     },
+    "config": {
+        "sort-packages": true
+    },
     "scripts": {
         "post-install-cmd": [
             "@composer bin all install --ansi"
         ],
         "post-update-cmd": [
             "@composer bin all install --ansi"
-        ],
-        "coverage": "vendor/bin/phpunit --colors=always --coverage-clover=build/logs/clover.xml",
-        "cs": "PHP_CS_FIXER_IGNORE_ENV=1 && vendor/bin/php-cs-fixer fix --verbose",
-        "cs-diff": "PHP_CS_FIXER_IGNORE_ENV=1 && vendor/bin/php-cs-fixer fix  --verbose --diff --dry-run",
-        "deps": "vendor/bin/composer-require-checker check --config-file composer-require.json composer.json",
-        "infection": "vendor/bin/infection",
-        "lint": [
-            "find ./src \\( -name '*.xml' -or -name '*.xml.dist' -or -name '*.xlf' \\) -type f -exec xmllint --encode UTF-8 --output '{}' --format '{}' \\;",
-            "find ./src \\( -name '*.yml' -or -name '*.yaml' \\) -not -path '*/vendor/*' | xargs yaml-lint"
-        ],
-        "phpmd": "vendor/bin/phpmd src,tests ansi phpmd.xml",
-        "phpstan": "vendor/bin/phpstan analyse",
-        "test": "vendor/bin/phpunit --colors=always"
-    },
-    "funding": [
-        {
-            "type": "github",
-            "url": "https://github.com/sponsors/core23"
-        },
-        {
-            "type": "opencollective",
-            "url": "https://opencollective.com/core23"
-        },
-        {
-            "type": "ko-fi",
-            "url": "https://ko-fi.com/core23"
-        },
-        {
-            "type": "other",
-            "url": "https://donate.core23.de"
-        }
-    ]
+        ]
+    }
 }
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -2,14 +2,11 @@ includes:
     - phpstan-baseline.neon
 
 parameters:
-    level: max
+    level: 8
 
     paths:
         - src
         - tests
 
     bootstrapFiles:
         - vendor-bin/tools/vendor/autoload.php
-
-    excludes_analyse:
-        - tests/bootstrap.php
diff --git a/vendor-bin/tools/composer.json b/vendor-bin/tools/composer.json
@@ -1,28 +1,30 @@
 {
     "name": "nucleos/dev-tools",
-    "type": "project",
     "description": "Development tools that do not conflict the project dependencies",
+    "type": "project",
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "^3.0",
-        "jangregor/phpstan-prophecy": "^0.8",
-        "maglnet/composer-require-checker": "^2.0",
-        "matthiasnoback/symfony-dependency-injection-test": "^4.0",
-        "phpmd/phpmd": "^2.9",
+        "friendsofphp/php-cs-fixer": "^3.3",
+        "jangregor/phpstan-prophecy": "^1.0",
+        "maglnet/composer-require-checker": "^3.5",
+        "matthiasnoback/symfony-dependency-injection-test": "^4.3",
+        "phpmd/phpmd": "^2.10",
         "phpspec/prophecy-phpunit": "^2.0",
         "phpstan/extension-installer": "^1.0",
-        "phpstan/phpstan": "^0.12",
-        "phpstan/phpstan-phpunit": "^0.12",
-        "phpstan/phpstan-strict-rules": "^0.12",
-        "phpstan/phpstan-symfony": "^0.12",
-        "phpunit/phpunit": "^8.5 || ^9.0",
+        "phpstan/phpstan": "^1.0",
+        "phpstan/phpstan-doctrine": "^1.0",
+        "phpstan/phpstan-phpunit": "^1.0",
+        "phpstan/phpstan-strict-rules": "^1.0",
+        "phpstan/phpstan-symfony": "^1.0",
+        "phpunit/phpunit": "^9.5",
         "psalm/plugin-phpunit": "^0.16",
         "psalm/plugin-symfony": "^3.0",
-        "symfony/phpunit-bridge": "^5.1",
-        "vimeo/psalm": "^4.3.1"
+        "symfony/phpunit-bridge": "^6.0",
+        "vimeo/psalm": "^4.13"
     },
     "config": {
+        "bin-dir": "../../vendor/bin",
         "platform": {
-            "php": "8.0"
+            "php": "8.0.2"
         }
     }
 }