Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up descriptions in some alerts #940

Closed
falz opened this issue Oct 24, 2022 · 3 comments
Closed

Tighten up descriptions in some alerts #940

falz opened this issue Oct 24, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@falz
Copy link
Contributor

falz commented Oct 24, 2022

Cosmetic suggestion. TLDR: tweak alert texts to be 'just the facts'.

Some alerts have some extra text in them that seems unneccessary. When a new prefix is found, monitorNewPrefix.js has this text:

Possible change of configuration. A new prefix ${message.prefix} is announced by ${message.originAS}. It is a more specific of ${matchedRule.prefix} (${matchedRule.description})

Suggestion to eliminate the Possible change of configuration. to keep it concise and remove speculation which could be a red herring to a network operator that sees the alert. Ie cause could be anything - config change, circuit down, device down, etc.

This was the only alert message that seemed to have this "issue". Cheers

@falz falz added the bug Something isn't working label Oct 24, 2022
@massimocandela massimocandela added enhancement New feature or request and removed bug Something isn't working labels Oct 24, 2022
@massimocandela
Copy link
Member

Hi @falz,

The Possible change of configuration refers to the BGPalerter configuration (and not routing). The original idea was to prompt the user to update the list of prefixes with the new prefix (if legit). Some users don't update the prefix list and the BGPalerter installation becomes noisy over time.

However, I do see your point. The current phrasing may complicate things without really convey what I meant. Let's see if I can find a better wording that would allow me to keep the suggestion of updating prefixes.yml.

@falz
Copy link
Contributor Author

falz commented Oct 25, 2022

That description of Configuration makes sense, thanks. I guess it was enough of a red herring to confuse myself!

@massimocandela
Copy link
Member

Hi @falz,

I changed the summary (self explanatory here). This will go out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants