Improved ASN.1 parsing for Keberos. Fixes #1492. #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
force-pushed
the
improved/kerberos-asn1-parsing
branch
from
5f24ff0 to
986c9fc
Compare
utoni
force-pushed
the
improved/kerberos-asn1-parsing
branch
from
986c9fc to
9179ba1
Compare
IvanNardi
reviewed
Apr 2, 2022
utoni
force-pushed
the
improved/kerberos-asn1-parsing
branch
3 times, most recently
from
682f937 to
752ae64
Compare
* This is a quick fix, the Kerberos protocol dissector requires some refactoring effort. Signed-off-by: Toni Uhlig <[email protected]> Signed-off-by: lns <[email protected]>
utoni
force-pushed
the
improved/kerberos-asn1-parsing
branch
from
752ae64 to
2cdd57b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Further Kerberos refactoring will be part of a follow-up. |
IvanNardi
approved these changes
Apr 10, 2022
hl33ta
pushed a commit
to ThreatEye/nDPI
that referenced
this pull request
May 12, 2022
* This is a quick fix, the Kerberos protocol dissector requires some refactoring effort. Signed-off-by: Toni Uhlig <[email protected]> Signed-off-by: lns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Toni Uhlig [email protected]