Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add GitHub Actions test runner. #30

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

carlosperate
Copy link
Contributor

@carlosperate carlosperate commented Nov 3, 2021

This PR adds CI testing via GitHub Actions.

The tests currently fail with Python 2.7 and 3.4, so they haven't been added.

@ntoll ntoll merged commit cfd35b8 into ntoll:master Nov 3, 2021
@ntoll
Copy link
Owner

ntoll commented Nov 3, 2021

Thank you (as ever) @carlosperate

@ntoll
Copy link
Owner

ntoll commented Nov 3, 2021

@carlosperate
Copy link
Contributor Author

Weird, it was passing in my fork: https://github.com/carlosperate/microfs/actions/runs/1417787732

I'll take a look.

@carlosperate
Copy link
Contributor Author

Interesting, since I created the commit and the PR was merged the macos-latest image has moved from macOS 10.15 to 11. I think we need to update pyserial, do you know why that version was locked?

@carlosperate
Copy link
Contributor Author

I think we can set up a min version instead: d005058#r19890391

@ntoll
Copy link
Owner

ntoll commented Nov 3, 2021

I can't remember (if I'm honest). Updating min version sounds like a plan. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants