Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage the use of target servers - Rule #19

Closed
ahemanna opened this issue Sep 7, 2018 · 3 comments
Closed

Encourage the use of target servers - Rule #19

ahemanna opened this issue Sep 7, 2018 · 3 comments

Comments

@ahemanna
Copy link

ahemanna commented Sep 7, 2018

In scenarios like the CORS preflight checks it is not required to hit the target and hence a NoRoute RouteRule will be configured. Is there a way to tell the SonarQube not to highlight this as an issue?

@ntiss
Copy link
Owner

ntiss commented Oct 2, 2018

Hi @ahemanna
Thank you for your feedback. I agree with you and I'll consider improving the detection of this issue in a next release.
For now, you can simply flag the issue as "Resolve as false positive" in Sonar itself once beeing logged in.

@ntiss
Copy link
Owner

ntiss commented Dec 21, 2018

Hello @ahemanna
I'll work on this issue very soon. Could you provide me a sample apiproxy.zip (containing nothing confidential) showing what you're expecting, please ? I think the a proxy with only 1 policy and 1 NoRoute would be suffisant to reproduce the bug.
This will be really helpful for the unit tests.

ntiss added a commit to CreditMutuelArkea/sonar-apigee-plugin that referenced this issue Jan 10, 2019
@ntiss
Copy link
Owner

ntiss commented Jan 10, 2019

@ahemanna
Fixed in this release : https://github.com/CreditMutuelArkea/sonar-apigee-plugin/releases/tag/v1.3.1
I won't publish it as official release through Sonar Marketplace because I'm still working on another issue. Just put the JAR file in your .../extensions/plugins directory.

Any feedback will be appreciated.

@ntiss ntiss closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants