Make S3 endpoint configurable #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,9 @@ function populateS3Options(env): Object { | |||
| // trim off trailing slashes | |||
| .replace(/\/+$/, ""); | |||
|
|
|||
| const s3Endpoint = | |||
| env.COMMUTER_S3_ENDPOINT || ""; | |||
There was a problem hiding this comment.
Is it valid to provide an empty string as the default value in this case? Assuming it won't error when consumed by any APIs....
There was a problem hiding this comment.
@captainsafia , thanks for reviewing my PR.
If we set config.endpoint as "" or null or 0, the aws-sdk-js will set proper endpoint automatically.
https://github.com/aws/aws-sdk-js/blob/b142e6c92bac747df4d65e4befc9960bbf15e0d4/lib/service.js#L53-L56
However, I'm sorry that I tested this PR with my customized s3 only, not AWS. Would you please test this using AWS?
|
@captainsafia Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMMUTER_S3_ENDPOINT) to use your own S3 endpoint.