Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new flying ace picture and updated bot message input to lower case values #47

Merged
merged 2 commits into from
Sep 13, 2020

Conversation

ryanmcnair
Copy link
Contributor

@ryanmcnair ryanmcnair commented Sep 13, 2020

Description

Added a new flying ace bot picture and added .lowerCase() to addMessage.js line 39. Bots will now reply when you type in all caps.

Related Issue

Related to #46

Motivation and Context

Message input is not case sensitive for a bot to reply

How Can This Be Tested?

git fetch origin bugfix

Screenshots (if appropriate):

Screen Shot 2020-09-13 at 7 00 02 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@bandstrar bandstrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

Copy link
Contributor

@michaelpfohl michaelpfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also committed my change of adding + i to the IDs for bot messages to this branch, ready for merge.

@ryanmcnair ryanmcnair merged commit acc9105 into development Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants