Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: /debug/pprof/symbol needs to allow POST #710

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

absolute8511
Copy link
Contributor

No description provided.

@jehiah jehiah added the bug label Jan 15, 2016
@jehiah
Copy link
Member

jehiah commented Jan 15, 2016

@absolute8511 is POST only needed for /debug/pprof/symbol not the other endpoints?

@absolute8511
Copy link
Contributor Author

That's right, it is needed by the go tool along with go 1.5

@mreiferson
Copy link
Member

cool, LGTM

mreiferson added a commit that referenced this pull request Jan 15, 2016
should allow POST method, since the newer go tool pprof need it.
@mreiferson mreiferson merged commit e25051d into nsqio:master Jan 15, 2016
@mreiferson mreiferson changed the title should allow POST method, since the newer go tool pprof need it. nsqd: /debug/pprof/symbol needs to allow POST Jan 15, 2016
@absolute8511 absolute8511 deleted the fix-debug-profile branch August 8, 2017 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants