Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-nsq to v1.0.0-alpha #357

Merged
merged 8 commits into from
May 28, 2014
Merged

Conversation

mreiferson
Copy link
Member

@s-mang
Copy link
Contributor

s-mang commented May 27, 2014

👍

@mreiferson
Copy link
Member Author

@adams-sarah - have you experimented with the new go-nsq API? what do you think?

@s-mang
Copy link
Contributor

s-mang commented May 27, 2014

Just moved over to the new go-nsq. I like the more-consistent nomenclature, and the one config struct.

Kind of a bummer that bitly/nsq relies on bitly/go-nsq, and vise versa. Makes the release not quite as smooth. I ended up just merging your PR branch into our fork of NSQ, so our builds are green again.

Nice work overall! Cheers 🍸

@mreiferson
Copy link
Member Author

Cool, thanks.

I started to pull things apart here for those exact reasons. The only spots, on this side, that still depend on go-nsq are tests that simulate a client (and it makes sense to continue using there, I think).

@mreiferson
Copy link
Member Author

RFR @jehiah

jehiah added a commit that referenced this pull request May 28, 2014
@jehiah jehiah merged commit b32c14a into nsqio:master May 28, 2014
@mreiferson mreiferson deleted the go_nsq_bump_357 branch May 28, 2014 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants