Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsq_to_file: new flag -rotate-check-interval #1071

Merged
merged 1 commit into from
Aug 20, 2018
Merged

nsq_to_file: new flag -rotate-check-interval #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/nsq_to_file/file_logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (f *FileLogger) router(r *nsq.Consumer) {
pos := 0
output := make([]*nsq.Message, *maxInFlight)
sync := false
ticker := time.NewTicker(time.Duration(30) * time.Second)
ticker := time.NewTicker(*rotateCheckInterval)
closing := false
closeFile := false
exit := false
Expand Down
1 change: 1 addition & 0 deletions apps/nsq_to_file/nsq_to_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ var (

rotateSize = flag.Int64("rotate-size", 0, "rotate the file when it grows bigger than `rotate-size` bytes")
rotateInterval = flag.Duration("rotate-interval", 0*time.Second, "rotate the file every duration")
rotateCheckInterval = flag.Duration("rotate-check-interval", 30*time.Second, "check whether the file should be rotated every duration")
Copy link
Member

@ploxiln ploxiln Aug 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think name and description is not really right - the check whether the file should be rotated is done on every single message, this really just affects how often the files are synced to disk (including empty files I guess)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, what do you have in mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "sync-interval" makes sense. description is a bit harder ... "sync current file on disk every duration" ... "(also check if file should should have been rotated since the last message received)"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I agree, --sync-interval makes more sense. I can whip that up or do you wanna do the honors @alpaker?

Copy link
Contributor Author

@alpaker alpaker Aug 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Regarding the description: If we're going to foreground the flush interval as what's controlled by this option, then I suggest omitting mention of rotation altogether. That the need for rotation is checked on msg receipt isn't explicitly documented, which makes the significance of "check if file should should have been rotated since the last message received" unclear. How about:

syncInterval = flag.Duration("sync-interval", 30*time.Second, "flush file to disk every duration")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, except s/flush/sync to match the flag name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me, I was just trying to appease the reasoning behind the original naming :)


httpConnectTimeout = flag.Duration("http-client-connect-timeout", 2*time.Second, "timeout for HTTP connect")
httpRequestTimeout = flag.Duration("http-client-request-timeout", 5*time.Second, "timeout for HTTP request")
Expand Down