Skip to content

Commit

Permalink
Merge pull request #1462 from dudleycarr/fix-admin-check-tombstoneNod…
Browse files Browse the repository at this point in the history
…eForTopic

nsqadmin: add admin check for topic/node thombstone endpoint
jehiah authored Oct 24, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 0967366 + fc75506 commit 9a8c304
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions nsqadmin/http.go
Original file line number Diff line number Diff line change
@@ -408,6 +408,10 @@ func (s *httpServer) nodeHandler(w http.ResponseWriter, req *http.Request, ps ht
func (s *httpServer) tombstoneNodeForTopicHandler(w http.ResponseWriter, req *http.Request, ps httprouter.Params) (interface{}, error) {
var messages []string

if !s.isAuthorizedAdminRequest(req) {
return nil, http_api.Err{403, "FORBIDDEN"}
}

node := ps.ByName("node")

var body struct {

0 comments on commit 9a8c304

Please sign in to comment.