Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: clone struct item on SETITEM, close #972 #975

Merged
merged 1 commit into from
May 21, 2020

Conversation

roman-khimov
Copy link
Member

It's the same as with APPEND and VALUES.

It's the same as with APPEND and VALUES.
@roman-khimov roman-khimov added the vm VM tasks/bugs/issues label May 21, 2020
@roman-khimov roman-khimov requested a review from fyrchik May 21, 2020 15:00
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #975 into master-2.x will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x     #975      +/-   ##
==============================================
- Coverage       68.00%   67.99%   -0.02%     
==============================================
  Files             145      145              
  Lines           14312    14313       +1     
==============================================
- Hits             9733     9732       -1     
- Misses           4119     4121       +2     
  Partials          460      460              
Impacted Files Coverage Δ
pkg/vm/vm.go 86.66% <100.00%> (+0.01%) ⬆️
pkg/rpc/client/wsclient.go 84.35% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07fd4f...f8b41e4. Read the comment docs.

@roman-khimov roman-khimov merged commit fb9b2ae into master-2.x May 21, 2020
@roman-khimov roman-khimov deleted the clone-struct-in-setitem-2.x branch May 21, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants