rpc: unify RPC handlers and metrics #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=========================================
- Coverage 66.96% 66.76% -0.2%
=========================================
Files 141 141
Lines 13045 12961 -84
=========================================
- Hits 8735 8653 -82
+ Misses 3900 3898 -2
Partials 410 410
Continue to review full report at Codecov.
|
Move getbestblockhash, getblockcount, getconnectioncount RPC.
Move all of them to a map. This can make it easier to add/remove RPC based on plugins and makes code less verbose.
roman-khimov
approved these changes
Mar 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to enable/disable RPC when needed (e.g.
getnep5*) and is easier to read.This is a draft for a discussion.