compiler: refactor AppCall #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fyrchik
commented
Feb 10, 2020
fyrchik
commented
- Make AppCall accept varargs.
- Fix a bug with argument order on stack.
Extract logic of reversing top n items of the stack in a separate function.
Invoked contract is expecting first argument to be on top of the stack. Change test to use non-commutative operation to catch this behaviour.
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 65.07% 65.09% +0.01%
==========================================
Files 125 125
Lines 10560 10565 +5
==========================================
+ Hits 6872 6877 +5
Misses 3410 3410
Partials 278 278 Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.