Feature/rpc and serialize fixes #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
- Coverage 62.5% 62.27% -0.23%
==========================================
Files 123 123
Lines 9990 10028 +38
==========================================
+ Hits 6244 6245 +1
- Misses 3445 3481 +36
- Partials 301 302 +1
Continue to review full report at Codecov.
|
volekerb
force-pushed
the
feature/rpc_and_serialize_fixes
branch
from
d3416ba to
6c2a34a
Compare
There was a problem hiding this comment.
And it would be nice to improve 4798d6c commit message, because it's adding unmarshalling for specific data type. Not critical, though.
pkg/core/transaction/type.go
Outdated
| @@ -52,3 +58,44 @@ func (t TXType) String() string { | |||
| func (t TXType) MarshalJSON() ([]byte, error) { | |||
| return []byte(`"` + t.String() + `"`), nil | |||
| } | |||
|
|
|||
| // UnmarshalJSON implements the json.Unmarshaler interface. | |||
| func (t *TXType) UnmarshalJSON(data []byte) (err error) { | |||
pkg/core/transaction/type.go
Outdated
| } | ||
|
|
||
| *t, err = TXTypeFromString(string(data[1 : l-1])) | ||
| return |
volekerb
force-pushed
the
feature/rpc_and_serialize_fixes
branch
from
ce4f399 to
6066166
Compare
done |
roman-khimov
approved these changes
Dec 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing unmarshal function for TXType and missing parametrization for "getblock" so it can return pure bytes
...
Solution
this patchset
...