cli/wallet: use more secure way to read passwords #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were printed in plaintext, believe it or not. Also, `ssh/terminal` does some proper magic to really read something from the terminal.
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 56.92% 56.92%
=======================================
Files 121 121
Lines 9822 9822
=======================================
Hits 5591 5591
Misses 3895 3895
Partials 336 336Continue to review full report at Codecov.
|
volekerb
approved these changes
Dec 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were printed in plaintext, believe it or not. Also,
ssh/terminaldoessome proper magic to really read something from the terminal.