core: fix too many nesting levels bug
#3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3810 +/- ##
==========================================
- Coverage 82.89% 82.88% -0.02%
==========================================
Files 338 338
Lines 47422 47422
==========================================
- Hits 39309 39304 -5
- Misses 6496 6499 +3
- Partials 1617 1619 +2 ☔ View full report in Codecov by Sentry. |
The C# implementation only decrements the nesting depth once in the parent composite condition (And, Or, or Not) and then passes that already‐decremented value onto its subconditions without further decrementing inside the loop. Close #3809 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
nested-levels
branch
from
a0677f8 to
75d1208
Compare
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
roman-khimov
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3809