network: take into account good known peers when thinking of GetAddr #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will be returned to pool when disconnected anyway. On a smaller network this can make a difference because there are not a lot of addresses in the pool usually. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
tune-getaddr-trigger
branch
from
2f5ca86 to
703bf6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3730 +/- ##
==========================================
+ Coverage 82.81% 82.90% +0.08%
==========================================
Files 335 335
Lines 46847 46847
==========================================
+ Hits 38798 38839 +41
+ Misses 6454 6413 -41
Partials 1595 1595 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
approved these changes
Dec 6, 2024
|
Let me check one thing. |
|
OK, good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will be returned to pool when disconnected anyway. On a smaller network this can make a difference because there are not a lot of addresses in the pool usually.