network: fix "unexpected empty payload: CMDVersion" #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can have _a lot_ of these in the log, but the only reason they happen is because we're trying to interpret length before checking for reader error, CMDVersion is just 0. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3726 +/- ##
=======================================
Coverage 82.83% 82.84%
=======================================
Files 335 335
Lines 46846 46847 +1
=======================================
+ Hits 38807 38810 +3
+ Misses 6448 6446 -2
Partials 1591 1591 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have a lot of these in the log, but the only reason they happen is because we're trying to interpret length before checking for reader error, CMDVersion is just 0.