Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockfetcher: decrease default pool deal timeout #3723

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

AnnaShaleva
Copy link
Member

Dealing is fast, we don't need 10 minutes to check that connection can (or can't) be established. Improve documentation along the way.

Close #3721.

Dealing is fast, we don't need 10 minutes to check that connection can
(or can't) be established. Improve documentation along the way.

Close #3721.

Signed-off-by: Anna Shaleva <[email protected]>
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.89%. Comparing base (0879018) to head (2244d2a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3723      +/-   ##
==========================================
+ Coverage   82.81%   82.89%   +0.07%     
==========================================
  Files         335      335              
  Lines       46846    46846              
==========================================
+ Hits        38797    38831      +34     
+ Misses       6454     6418      -36     
- Partials     1595     1597       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely will be improved with the next SDK version, some errors (like incorrect address) were not catched early previously.

@roman-khimov roman-khimov merged commit 8952922 into master Dec 4, 2024
34 checks passed
@roman-khimov roman-khimov deleted the fix-deal-timeout branch December 4, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoFSBlockFetcher may seem hanging
2 participants