Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix restoring chain with StateRootInHeader = true #3697

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3597

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.98%. Comparing base (cdbc026) to head (85c3b96).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3697      +/-   ##
==========================================
- Coverage   83.04%   82.98%   -0.06%     
==========================================
  Files         335      335              
  Lines       46708    46709       +1     
==========================================
- Hits        38787    38760      -27     
- Misses       6328     6359      +31     
+ Partials     1593     1590       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least it's not that bad and can be fixed easily.

pkg/core/stateroot/module.go Outdated Show resolved Hide resolved
pkg/core/stateroot/module.go Show resolved Hide resolved
@AliceInHunterland AliceInHunterland force-pushed the logs-for-cash branch 2 times, most recently from e221649 to 5fec492 Compare November 22, 2024 09:29
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

pkg/core/blockchain_core_test.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva merged commit 3d3f3f6 into master Nov 25, 2024
33 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the logs-for-cash branch November 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring chain with StateRootInHeader = true can fail
3 participants