Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap: add ErrNull to handle Null returned, fix #2795 #3695

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

roman-khimov
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (2b758c5) to head (3d00a19).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
+ Coverage   82.98%   83.06%   +0.08%     
==========================================
  Files         335      335              
  Lines       46708    46719      +11     
==========================================
+ Hits        38759    38808      +49     
+ Misses       6360     6320      -40     
- Partials     1589     1591       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

pkg/rpcclient/unwrap/unwrap.go Show resolved Hide resolved
@roman-khimov roman-khimov merged commit ff15e39 into master Nov 22, 2024
34 checks passed
@roman-khimov roman-khimov deleted the add-unwrap-errnull branch November 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants